Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add T5 to AutoConverter #4477

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Add T5 to AutoConverter #4477

merged 6 commits into from
Jan 17, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented Jan 13, 2023 •
edited
Loading

PR types

PR changes

Description

Tested the following models:

model = T5ForConditionalGeneration.from_pretrained("hf-internal-testing/tiny-random-T5Model", from_hf_hub=True)
model = T5ForConditionalGeneration.from_pretrained("hf-internal-testing/tiny-random-t5-v1.1", from_hf_hub=True)
model = T5ForConditionalGeneration.from_pretrained("t5-small", from_hf_hub=True)
model = T5ForConditionalGeneration.from_pretrained("google/t5-v1_1-small", from_hf_hub=True)
model = T5ForConditionalGeneration.from_pretrained("ClueAI/PromptCLUE-base", from_hf_hub=True)
model = T5ForConditionalGeneration.from_pretrained("ClueAI/ChatYuan-large-v1", from_hf_hub=True)

@paddle-bot
Copy link

paddle-bot bot commented Jan 13, 2023

Thanks for your contribution!

@sijunhe sijunhe requested a review from wj-Mcat January 16, 2023 09:07
@sijunhe sijunhe marked this pull request as ready for review January 16, 2023 09:33
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #4477 (d315a37) into develop (689428a) will increase coverage by 0.01%.
The diff coverage is 83.87%.

@@             Coverage Diff             @@
##           develop    #4477      +/-   ##
===========================================
+ Coverage    41.27%   41.29%   +0.01%     
===========================================
  Files          432      432              
  Lines        61705    61733      +28     
===========================================
+ Hits         25468    25490      +22     
- Misses       36237    36243       +6
Impacted Files Coverage Δ
paddlenlp/utils/serialization.py 88.05% <75.00%> (-0.23%) ⬇️
paddlenlp/transformers/t5/modeling.py 84.82% <86.95%> (-0.26%) ⬇️
paddlenlp/transformers/roberta/modeling.py 89.81% <0.00%> (-0.37%) ⬇️
paddlenlp/transformers/nezha/modeling.py 20.60% <0.00%> (-0.34%) ⬇️
paddlenlp/utils/downloader.py 58.19% <0.00%> (+0.40%) ⬆️
paddlenlp/transformers/activations.py 78.68% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JunnYu
JunnYu previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijunhe sijunhe merged commit c1359cb into PaddlePaddle:develop Jan 17, 2023
@sijunhe sijunhe deleted the t5_conversion branch January 17, 2023 05:16
@sijunhe sijunhe mentioned this pull request Feb 9, 2023
Closed
5 tasks
@cloud2009 cloud2009 mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunnYu JunnYu JunnYu approved these changes

@wj-Mcat wj-Mcat Awaiting requested review from wj-Mcat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sijunhe @JunnYu